Added device tree overlays for the rpi-power HAT. #7036
Conversation
pelwell
left a comment
pelwell
left a comment
There was a problem hiding this comment.
I've added a few inline comments, but the main issues that that the automatic checks will flag up is that every overlay needs a rule in the Makefile to build it and an entry in the README file.
| target-path = "/"; | ||
| __overlay__ { | ||
| rpi_power_hat_b: rpi-power-hat-b { | ||
| compatible = "Raspberry Pi,rpi-power-hat-b"; |
There was a problem hiding this comment.
The correct prefix for Raspberry Pi Ltd. is "raspberrypi".
| }; | ||
| }; | ||
| }; | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Git prefers all files to end with a newline.
| power2-monitor = <&pwr2_monitor>; | ||
|
|
||
| // HAT metadata | ||
| hat-name = "rpi-power-hat Bottom"; |
There was a problem hiding this comment.
I'm not sure what this is meant to do. If it's for human readability, the compatible string should be enough.
arch/arm/boot/dts/overlays/Makefile
Outdated
| rpi-fw-uart.dtbo \ | ||
| rpi-poe.dtbo \ | ||
| rpi-poe-plus.dtbo \ | ||
| rpi-power-hat-b-overlay.dtbo \ |
There was a problem hiding this comment.
The make rules transform *-overlay.dts into *.dtbo, so drop the -overlays here.
LucasH-rp
force-pushed
the
rpi-6.12.y
branch
from
492b567 to
d2f1b8f
Compare
|
If you run |
|
And the overlay entries in README and Makefile must be in alphabetical order. |
LucasH-rp
force-pushed
the
rpi-6.12.y
branch
from
d2f1b8f to
9d045b3
Compare
|
Checkpatch is complaining about undocumented DT compatible strings and MAINTAINERS needing updating - is it okay to ignore these warnings? |
|
Yes, I'll waive those. |
Added 2 overlays for the rpi-power HAT to operate in either TOP or BOTTOM mode. Modified makefile and readme accordingly Signed-off-by: Lucas Hoffmann <[email protected]>
LucasH-rp
force-pushed
the
rpi-6.12.y
branch
from
9d045b3 to
845f06f
Compare
kernel: configs: Add EROFS_FS_ZIP_ZSTD See: raspberrypi/linux#7028 kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400 See: raspberrypi/linux#7031 kernel: mfd: rp1: Fix device links when modules disabled See: raspberrypi/linux#7027 kernel: Add adxl355 to i2c-sensor See: raspberrypi/linux#6823 kernel: dtoverlays: Switch ssd1306 to use the DRM driver See: raspberrypi/linux#7034 kernel: Added device tree overlays for the rpi-power HAT See: raspberrypi/linux#7036 kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8 See: raspberrypi/linux#7037
kernel: configs: Add EROFS_FS_ZIP_ZSTD See: raspberrypi/linux#7028 kernel: dt: Add eth_max_speed override for CM4, Pi4, and Pi400 See: raspberrypi/linux#7031 kernel: mfd: rp1: Fix device links when modules disabled See: raspberrypi/linux#7027 kernel: Add adxl355 to i2c-sensor See: raspberrypi/linux#6823 kernel: dtoverlays: Switch ssd1306 to use the DRM driver See: raspberrypi/linux#7034 kernel: Added device tree overlays for the rpi-power HAT See: raspberrypi/linux#7036 kernel: fixup! misc: rp1-pio: Request a DMA burst size of 8 See: raspberrypi/linux#7037
2 participants
Added 2 device tree overlays for the rpi-control-hat. One for 'bottom' mode and one for 'top' mode.